Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/core): add experimental theme demo #29636

Merged
merged 1 commit into from
Aug 26, 2024
Merged

feat(material/core): add experimental theme demo #29636

merged 1 commit into from
Aug 26, 2024

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Aug 23, 2024 •
edited
Loading

Preview: https://ng-dev-previews-comp--pr-angular-components-29636-dev-6fy759rh.web.app/theme

Be sure to enable M3 and System Theme in the header

@andrewseguin andrewseguin requested a review from a team as a code owner August 23, 2024 15:41
@andrewseguin andrewseguin requested review from crisbeto and amysorto and removed request for a team August 23, 2024 15:41
@andrewseguin andrewseguin added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Aug 23, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Aug 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

Deployed dev-app for 4a90895 to: https://ng-dev-previews-comp--pr-angular-components-29636-dev-6fy759rh.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

crisbeto
crisbeto approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't see any differences when I toggle the new theme.

.stylelintrc.json Show resolved Hide resolved
src/dev-app/dev-app/dev-app-layout.html Outdated Show resolved Hide resolved
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Aug 26, 2024
@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Aug 26, 2024
@andrewseguin andrewseguin merged commit 64ed7ca into angular:main Aug 26, 2024
23 of 26 checks passed
@WontonSam WontonSam mentioned this pull request Sep 11, 2024
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewseguin @crisbeto